fix: tests with validation errors were skipped (#2496)

* fix: tests with validation errors were skipped

* fixup

* [no ci] fix one test

* fix some tests

* fix last test

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

pkg/runner/testdata/shells/bash/push.yml

@@ -5,7 +5,7 @@ jobs:
   check:
     runs-on: ubuntu-latest
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: bash
         run: |
           if [[ -n "$BASH" ]]; then
             echo "I'm $BASH!"
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     container: node:16-buster-slim
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: bash
         run: |
           if [[ -n "$BASH" ]]; then
             echo "I'm $BASH!"

pkg/runner/testdata/shells/pwsh/push.yml

@@ -5,14 +5,14 @@ jobs:
   check:
     runs-on: ubuntu-latest
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: pwsh
         run: |
           $PSVersionTable
   check-container:
     runs-on: ubuntu-latest
     container: catthehacker/ubuntu:pwsh-latest
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: pwsh
         run: |
           $PSVersionTable
   check-job-default:

pkg/runner/testdata/shells/python/push.yml

@@ -5,7 +5,7 @@ jobs:
   check:
     runs-on: ubuntu-latest
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: python
         run: |
           import platform
           print(platform.python_version())
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     container: node:16-buster
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: python
         run: |
           import platform
           print(platform.python_version())

pkg/runner/testdata/shells/sh/push.yml

@@ -5,7 +5,7 @@ jobs:
   check:
     runs-on: ubuntu-latest
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: sh
         run: |
           if [ -z ${BASH+x} ]; then
             echo "I'm sh!"
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     container: alpine:latest
     steps:
-      - shell: ${{ env.MY_SHELL }}
+      - shell: sh
         run: |
           if [ -z ${BASH+x} ]; then
             echo "I'm sh!"