From d8506bfa4f4ba0c632a1c3c521f4be85812d6c01 Mon Sep 17 00:00:00 2001 From: ChristopherHX Date: Wed, 11 Jun 2025 20:06:25 +0200 Subject: [PATCH] fix: valueMasker concurrent map write (#5026) * valueMasker create secrets copy Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- pkg/runner/logger.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/runner/logger.go b/pkg/runner/logger.go index a788f68..8fc8429 100644 --- a/pkg/runner/logger.go +++ b/pkg/runner/logger.go @@ -144,6 +144,10 @@ func withStepLogger(ctx context.Context, stepID string, stepName string, stageNa type entryProcessor func(entry *logrus.Entry) *logrus.Entry func valueMasker(insecureSecrets bool, secrets map[string]string) entryProcessor { + ssecrets := []string{} + for _, v := range secrets { + ssecrets = append(ssecrets, v) + } return func(entry *logrus.Entry) *logrus.Entry { if insecureSecrets { return entry @@ -151,7 +155,7 @@ func valueMasker(insecureSecrets bool, secrets map[string]string) entryProcessor masks := Masks(entry.Context) - for _, v := range secrets { + for _, v := range ssecrets { if v != "" { entry.Message = strings.ReplaceAll(entry.Message, v, "***") }