DevInfra/act_gitea
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add test for listartifacts v4 filter (#2507)

Browse Source 
* add test for listartifacts v4 filter

* fixes a defect of last change

* Update artifacts.yml

* use 32bit ids after cast to double we have a loss

* Update artifacts.yml
This commit is contained in:
ChristopherHX
2024-10-29 03:34:58 +01:00
committed by GitHub
parent 2c0e3fea00
commit e3b4e3aded
2 changed files with 47 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/artifacts/arifacts_v4.go
View File

@@ -121,9 +121,9 @@ type ArtifactContext struct {
}
func artifactNameToID(s string) int64 {
h := fnv.New64a()
h := fnv.New32a()
h.Write([]byte(s))
return int64(h.Sum64())
return int64(h.Sum32())
}
func (c ArtifactContext) Error(status int, _ ...interface{}) {
@@ -376,7 +376,7 @@ func (r *artifactV4Routes) listArtifacts(ctx *ArtifactContext) {
for _, entry := range entries {
id := artifactNameToID(entry.Name())
if (req.NameFilter == nil || req.NameFilter.Value == entry.Name()) || (req.IdFilter == nil || req.IdFilter.Value == id) {
if (req.NameFilter == nil || req.NameFilter.Value == entry.Name()) && (req.IdFilter == nil || req.IdFilter.Value == id) {
data := &ListArtifactsResponse_MonolithArtifact{
Name: entry.Name(),
CreatedAt: timestamppb.Now(),