thebestvibedev/tromcho.net
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make journal trimmer wait until reads are completed when inmemory_journal is false

Browse Source 
Without this new writes may in theory overwrite journal data being read at that time
This commit is contained in:
Vitaliy Filippov
2022-11-20 01:49:21 +03:00
parent 09a8864686
commit 238037ae31
3 changed files with 35 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blockstore_impl.h
+2 -1
View File
@@ -166,6 +166,7 @@ struct __attribute__((__packed__)) dirty_entry
struct fulfill_read_t
{
uint64_t offset, len;
uint64_t journal_sector; // sector+1 if used and !journal.inmemory, otherwise 0
};
#define PRIV(op) ((blockstore_op_private_t*)(op)->private_data)
@@ -305,7 +306,7 @@ class blockstore_impl_t
// Read
int dequeue_read(blockstore_op_t *read_op);
int fulfill_read(blockstore_op_t *read_op, uint64_t &fulfilled, uint32_t item_start, uint32_t item_end,
uint32_t item_state, uint64_t item_version, uint64_t item_location);
uint32_t item_state, uint64_t item_version, uint64_t item_location, uint64_t journal_sector);
int fulfill_read_push(blockstore_op_t *op, void *buf, uint64_t offset, uint64_t len,
uint32_t item_state, uint64_t item_version);
void handle_read_event(ring_data_t *data, blockstore_op_t *op);