thebestvibedev/tromcho.net
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix op_stable slowdowns

Browse Source
This commit is contained in:
Vitaliy Filippov
2025-12-02 01:52:12 +03:00
parent c980168d10
commit 4f997791b8
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blockstore/blockstore_stable.cpp
+1 -1
View File
@@ -65,7 +65,7 @@ resume_1:
if (priv->pending_ops > 0) if (priv->pending_ops > 0)
{ {
priv->op_state = 1; priv->op_state = 1;
return 0; return 1;
} }
// Mark writes as completed to allow compaction // Mark writes as completed to allow compaction
for (uint64_t lsn = priv->lsn; lsn <= priv->to_lsn; lsn++) for (uint64_t lsn = priv->lsn; lsn <= priv->to_lsn; lsn++)
src/blockstore/blockstore_write.cpp
+7 -3
View File
@@ -277,6 +277,7 @@ bool blockstore_impl_t::make_big_write(blockstore_op_t *op, uint32_t offset, uin
int blockstore_impl_t::continue_write(blockstore_op_t *op) int blockstore_impl_t::continue_write(blockstore_op_t *op)
{ {
int op_state = PRIV(op)->op_state; int op_state = PRIV(op)->op_state;
again:
if (op_state == 2) if (op_state == 2)
goto resume_2; goto resume_2;
else if (op_state == 4) else if (op_state == 4)
@@ -294,7 +295,11 @@ int blockstore_impl_t::continue_write(blockstore_op_t *op)
else else
{ {
// In progress // In progress
return 1; assert(op_state < 10);
if (PRIV(op)->pending_ops > 0)
return 1;
op_state++;
goto again;
} }
resume_2: resume_2:
// We must fsync all big writes to avoid complex write workflows // We must fsync all big writes to avoid complex write workflows
@@ -372,7 +377,7 @@ resume_6:
// Remember that the timer can in theory be called right here // Remember that the timer can in theory be called right here
tfd->set_timer_us(ref_us-exec_us, false, [this, op](int timer_id) tfd->set_timer_us(ref_us-exec_us, false, [this, op](int timer_id)
{ {
PRIV(op)->op_state++; PRIV(op)->op_state = 8;
ringloop->wakeup(); ringloop->wakeup();
}); });
return 1; return 1;
@@ -416,7 +421,6 @@ void blockstore_impl_t::handle_write_event(ring_data_t *data, blockstore_op_t *o
assert(PRIV(op)->pending_ops >= 0); assert(PRIV(op)->pending_ops >= 0);
if (PRIV(op)->pending_ops == 0) if (PRIV(op)->pending_ops == 0)
{ {
PRIV(op)->op_state++;
ringloop->wakeup(); ringloop->wakeup();
} }
} }