thebestvibedev/tromcho.net
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log RDMA ibv_modify_qp() errors

Browse Source
This commit is contained in:
Vitaliy Filippov
2025-03-22 15:58:13 +03:00
parent f544c350ba
commit 8b0389b4e8
2 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/messenger.cpp
+2 -2
View File
@@ -582,7 +582,7 @@ void osd_messenger_t::check_peer_config(osd_client_t *cl)
{ {
osd_num_t peer_osd = cl->osd_num; osd_num_t peer_osd = cl->osd_num;
stop_client(op->peer_fd); stop_client(op->peer_fd);
on_connect_peer(peer_osd, -1); on_connect_peer(peer_osd, -EINVAL);
delete op; delete op;
return; return;
} }
@@ -602,7 +602,7 @@ void osd_messenger_t::check_peer_config(osd_client_t *cl)
// FIXME: Keep TCP connection in this case // FIXME: Keep TCP connection in this case
osd_num_t peer_osd = cl->osd_num; osd_num_t peer_osd = cl->osd_num;
stop_client(cl->peer_fd); stop_client(cl->peer_fd);
on_connect_peer(peer_osd, -1); on_connect_peer(peer_osd, -EINVAL);
delete op; delete op;
return; return;
} }
src/client/msgr_rdma.cpp
+12 -10
View File
@@ -469,9 +469,10 @@ msgr_rdma_connection_t *msgr_rdma_connection_t::create(msgr_rdma_context_t *ctx,
.port_num = ctx->ib_port, .port_num = ctx->ib_port,
}; };
if (ibv_modify_qp(conn->qp, &attr, IBV_QP_STATE | IBV_QP_PKEY_INDEX | IBV_QP_PORT | IBV_QP_ACCESS_FLAGS)) int r = 0;
if ((r = ibv_modify_qp(conn->qp, &attr, IBV_QP_STATE | IBV_QP_PKEY_INDEX | IBV_QP_PORT | IBV_QP_ACCESS_FLAGS)) != 0)
{ {
fprintf(stderr, "Failed to switch RDMA queue pair to INIT state\n"); fprintf(stderr, "Failed to switch RDMA queue pair to INIT state: %s (code %d)\n", strerror(r), r);
delete conn; delete conn;
return NULL; return NULL;
} }
@@ -522,18 +523,19 @@ int msgr_rdma_connection_t::connect(msgr_rdma_address_t *dest)
.rnr_retry = 7, .rnr_retry = 7,
}; };
// FIXME No idea if ibv_modify_qp is a blocking operation or not. No idea if it has a timeout and what it is. // FIXME No idea if ibv_modify_qp is a blocking operation or not. No idea if it has a timeout and what it is.
if (ibv_modify_qp(conn->qp, &attr, IBV_QP_STATE | IBV_QP_AV | IBV_QP_PATH_MTU | int r;
IBV_QP_DEST_QPN | IBV_QP_RQ_PSN | IBV_QP_MAX_DEST_RD_ATOMIC | IBV_QP_MIN_RNR_TIMER)) if ((r = ibv_modify_qp(conn->qp, &attr, IBV_QP_STATE | IBV_QP_AV | IBV_QP_PATH_MTU |
IBV_QP_DEST_QPN | IBV_QP_RQ_PSN | IBV_QP_MAX_DEST_RD_ATOMIC | IBV_QP_MIN_RNR_TIMER)) != 0)
{ {
fprintf(stderr, "Failed to switch RDMA queue pair to RTR (ready-to-receive) state\n"); fprintf(stderr, "Failed to switch RDMA queue pair to RTR (ready-to-receive) state: %s (code %d)\n", strerror(r), r);
return 1; return -r;
} }
attr.qp_state = IBV_QPS_RTS; attr.qp_state = IBV_QPS_RTS;
if (ibv_modify_qp(conn->qp, &attr, IBV_QP_STATE | IBV_QP_TIMEOUT | if ((r = ibv_modify_qp(conn->qp, &attr, IBV_QP_STATE | IBV_QP_TIMEOUT |
IBV_QP_RETRY_CNT | IBV_QP_RNR_RETRY | IBV_QP_SQ_PSN | IBV_QP_MAX_QP_RD_ATOMIC)) IBV_QP_RETRY_CNT | IBV_QP_RNR_RETRY | IBV_QP_SQ_PSN | IBV_QP_MAX_QP_RD_ATOMIC)) != 0)
{ {
fprintf(stderr, "Failed to switch RDMA queue pair to RTS (ready-to-send) state\n"); fprintf(stderr, "Failed to switch RDMA queue pair to RTS (ready-to-send) state: %s (code %d)\n", strerror(r), r);
return 1; return -r;
} }
return 0; return 0;
} }