From a1ca573168f8461f3d3ea64f1d492d077d61d84d Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Thu, 7 Nov 2024 12:21:13 +0300 Subject: [PATCH] Support QEMU 9.1 --- patches/qemu-9.1-vitastor.patch | 172 ++++++++++++++++++++++++++++++++ src/client/qemu_driver.c | 5 +- 2 files changed, 176 insertions(+), 1 deletion(-) create mode 100644 patches/qemu-9.1-vitastor.patch diff --git a/patches/qemu-9.1-vitastor.patch b/patches/qemu-9.1-vitastor.patch new file mode 100644 index 00000000..2d05bb04 --- /dev/null +++ b/patches/qemu-9.1-vitastor.patch @@ -0,0 +1,172 @@ +diff --git a/block/meson.build b/block/meson.build +index f1262ec2ba..3cf3e23f16 100644 +--- a/block/meson.build ++++ b/block/meson.build +@@ -114,6 +114,7 @@ foreach m : [ + [libnfs, 'nfs', files('nfs.c')], + [libssh, 'ssh', files('ssh.c')], + [rbd, 'rbd', files('rbd.c')], ++ [vitastor, 'vitastor', files('vitastor.c')], + ] + if m[0].found() + module_ss = ss.source_set() +diff --git a/meson.build b/meson.build +index fbda17c987..3edac22aff 100644 +--- a/meson.build ++++ b/meson.build +@@ -1510,6 +1510,26 @@ if not get_option('rbd').auto() or have_block + endif + endif + ++vitastor = not_found ++if not get_option('vitastor').auto() or have_block ++ libvitastor_client = cc.find_library('vitastor_client', has_headers: ['vitastor_c.h'], ++ required: get_option('vitastor')) ++ if libvitastor_client.found() ++ if cc.links(''' ++ #include ++ int main(void) { ++ vitastor_c_create_qemu(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0); ++ return 0; ++ }''', dependencies: libvitastor_client) ++ vitastor = declare_dependency(dependencies: libvitastor_client) ++ elif get_option('vitastor').enabled() ++ error('could not link libvitastor_client') ++ else ++ warning('could not link libvitastor_client, disabling') ++ endif ++ endif ++endif ++ + glusterfs = not_found + glusterfs_ftruncate_has_stat = false + glusterfs_iocb_has_stat = false +@@ -2351,6 +2371,7 @@ endif + config_host_data.set('CONFIG_OPENGL', opengl.found()) + config_host_data.set('CONFIG_PLUGIN', get_option('plugins')) + config_host_data.set('CONFIG_RBD', rbd.found()) ++config_host_data.set('CONFIG_VITASTOR', vitastor.found()) + config_host_data.set('CONFIG_RDMA', rdma.found()) + config_host_data.set('CONFIG_RELOCATABLE', get_option('relocatable')) + config_host_data.set('CONFIG_SAFESTACK', get_option('safe_stack')) +@@ -4510,6 +4531,7 @@ summary_info += {'fdt support': fdt_opt == 'internal' ? 'internal' : fdt} + summary_info += {'libcap-ng support': libcap_ng} + summary_info += {'bpf support': libbpf} + summary_info += {'rbd support': rbd} ++summary_info += {'vitastor support': vitastor} + summary_info += {'smartcard support': cacard} + summary_info += {'U2F support': u2f} + summary_info += {'libusb': libusb} +diff --git a/meson_options.txt b/meson_options.txt +index 0269fa0f16..4740ffdc27 100644 +--- a/meson_options.txt ++++ b/meson_options.txt +@@ -194,6 +194,8 @@ option('lzo', type : 'feature', value : 'auto', + description: 'lzo compression support') + option('rbd', type : 'feature', value : 'auto', + description: 'Ceph block device driver') ++option('vitastor', type : 'feature', value : 'auto', ++ description: 'Vitastor block device driver') + option('opengl', type : 'feature', value : 'auto', + description: 'OpenGL support') + option('rdma', type : 'feature', value : 'auto', +diff --git a/qapi/block-core.json b/qapi/block-core.json +index aa40d44f1d..bbee6a0e9c 100644 +--- a/qapi/block-core.json ++++ b/qapi/block-core.json +@@ -3203,7 +3203,7 @@ + 'parallels', 'preallocate', 'qcow', 'qcow2', 'qed', 'quorum', + 'raw', 'rbd', + { 'name': 'replication', 'if': 'CONFIG_REPLICATION' }, +- 'ssh', 'throttle', 'vdi', 'vhdx', ++ 'ssh', 'throttle', 'vdi', 'vhdx', 'vitastor', + { 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' }, + { 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' }, + { 'name': 'virtio-blk-vhost-vdpa', 'if': 'CONFIG_BLKIO' }, +@@ -4286,6 +4286,28 @@ + '*key-secret': 'str', + '*server': ['InetSocketAddressBase'] } } + ++## ++# @BlockdevOptionsVitastor: ++# ++# Driver specific block device options for vitastor ++# ++# @image: Image name ++# @inode: Inode number ++# @pool: Pool ID ++# @size: Desired image size in bytes ++# @config-path: Path to Vitastor configuration ++# @etcd-host: etcd connection address(es) ++# @etcd-prefix: etcd key/value prefix ++## ++{ 'struct': 'BlockdevOptionsVitastor', ++ 'data': { '*inode': 'uint64', ++ '*pool': 'uint64', ++ '*size': 'uint64', ++ '*image': 'str', ++ '*config-path': 'str', ++ '*etcd-host': 'str', ++ '*etcd-prefix': 'str' } } ++ + ## + # @ReplicationMode: + # +@@ -4742,6 +4764,7 @@ + 'throttle': 'BlockdevOptionsThrottle', + 'vdi': 'BlockdevOptionsGenericFormat', + 'vhdx': 'BlockdevOptionsGenericFormat', ++ 'vitastor': 'BlockdevOptionsVitastor', + 'virtio-blk-vfio-pci': + { 'type': 'BlockdevOptionsVirtioBlkVfioPci', + 'if': 'CONFIG_BLKIO' }, +@@ -5183,6 +5206,20 @@ + '*cluster-size' : 'size', + '*encrypt' : 'RbdEncryptionCreateOptions' } } + ++## ++# @BlockdevCreateOptionsVitastor: ++# ++# Driver specific image creation options for Vitastor. ++# ++# @location: Where to store the new image file. This location cannot ++# point to a snapshot. ++# ++# @size: Size of the virtual disk in bytes ++## ++{ 'struct': 'BlockdevCreateOptionsVitastor', ++ 'data': { 'location': 'BlockdevOptionsVitastor', ++ 'size': 'size' } } ++ + ## + # @BlockdevVmdkSubformat: + # +@@ -5405,6 +5442,7 @@ + 'ssh': 'BlockdevCreateOptionsSsh', + 'vdi': 'BlockdevCreateOptionsVdi', + 'vhdx': 'BlockdevCreateOptionsVhdx', ++ 'vitastor': 'BlockdevCreateOptionsVitastor', + 'vmdk': 'BlockdevCreateOptionsVmdk', + 'vpc': 'BlockdevCreateOptionsVpc' + } } +diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh +index c97079a38c..4623f552ec 100644 +--- a/scripts/meson-buildoptions.sh ++++ b/scripts/meson-buildoptions.sh +@@ -168,6 +168,7 @@ meson_options_help() { + printf "%s\n" ' qga-vss build QGA VSS support (broken with MinGW)' + printf "%s\n" ' qpl Query Processing Library support' + printf "%s\n" ' rbd Ceph block device driver' ++ printf "%s\n" ' vitastor Vitastor block device driver' + printf "%s\n" ' rdma Enable RDMA-based migration' + printf "%s\n" ' replication replication support' + printf "%s\n" ' rutabaga-gfx rutabaga_gfx support' +@@ -444,6 +445,8 @@ _meson_option_parse() { + --disable-qpl) printf "%s" -Dqpl=disabled ;; + --enable-rbd) printf "%s" -Drbd=enabled ;; + --disable-rbd) printf "%s" -Drbd=disabled ;; ++ --enable-vitastor) printf "%s" -Dvitastor=enabled ;; ++ --disable-vitastor) printf "%s" -Dvitastor=disabled ;; + --enable-rdma) printf "%s" -Drdma=enabled ;; + --disable-rdma) printf "%s" -Drdma=disabled ;; + --enable-relocatable) printf "%s" -Drelocatable=true ;; diff --git a/src/client/qemu_driver.c b/src/client/qemu_driver.c index be80efda..50b81d8c 100644 --- a/src/client/qemu_driver.c +++ b/src/client/qemu_driver.c @@ -16,7 +16,6 @@ #include "qapi/error.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qerror.h" -#include "qemu/uri.h" #include "qemu/error-report.h" #include "qemu/module.h" #include "qemu/option.h" @@ -1021,7 +1020,11 @@ static BlockDriver bdrv_vitastor = { // FIXME: Implement it along with per-inode statistics //.bdrv_get_allocated_file_size = vitastor_get_allocated_file_size, +#if QEMU_VERSION_MAJOR > 9 || QEMU_VERSION_MAJOR == 9 && QEMU_VERSION_MINOR > 0 + .bdrv_open = vitastor_file_open, +#else .bdrv_file_open = vitastor_file_open, +#endif .bdrv_close = vitastor_close, // Option list for the create operation