thebestvibedev/tromcho.net
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add pg_size change check for XOR pools

Browse Source
This commit is contained in:
Vitaliy Filippov
2025-10-24 20:53:27 +03:00
parent d60709dce1
commit cad6ea0360
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cmd/cli_pool_cfg.cpp
+9 -1
View File
@@ -180,7 +180,8 @@ std::string validate_pool_config(json11::Json::object & new_cfg, json11::Json ol
{ {
return "Changing scheme for an existing pool will lead to data loss. Use --force to proceed"; return "Changing scheme for an existing pool will lead to data loss. Use --force to proceed";
} }
if (etcd_state_client_t::parse_scheme(old_cfg["scheme"].string_value()) == POOL_SCHEME_EC) auto old_scheme = etcd_state_client_t::parse_scheme(old_cfg["scheme"].string_value());
if (old_scheme == POOL_SCHEME_EC)
{ {
uint64_t old_data_chunks = old_cfg["pg_size"].uint64_value() - old_cfg["parity_chunks"].uint64_value(); uint64_t old_data_chunks = old_cfg["pg_size"].uint64_value() - old_cfg["parity_chunks"].uint64_value();
uint64_t new_data_chunks = cfg["pg_size"].uint64_value() - cfg["parity_chunks"].uint64_value(); uint64_t new_data_chunks = cfg["pg_size"].uint64_value() - cfg["parity_chunks"].uint64_value();
@@ -189,6 +190,13 @@ std::string validate_pool_config(json11::Json::object & new_cfg, json11::Json ol
return "Changing EC data chunk count for an existing pool will lead to data loss. Use --force to proceed"; return "Changing EC data chunk count for an existing pool will lead to data loss. Use --force to proceed";
} }
} }
else if (old_scheme != POOL_SCHEME_REPLICATED)
{
if (old_cfg["pg_size"].uint64_value() != cfg["pg_size"].uint64_value())
{
return "Changing XOR data chunk count for an existing pool will lead to data loss. Use --force to proceed";
}
}
if (old_cfg["block_size"] != cfg["block_size"] || if (old_cfg["block_size"] != cfg["block_size"] ||
old_cfg["bitmap_granularity"] != cfg["bitmap_granularity"] || old_cfg["bitmap_granularity"] != cfg["bitmap_granularity"] ||
old_cfg["immediate_commit"] != cfg["immediate_commit"]) old_cfg["immediate_commit"] != cfg["immediate_commit"])