thebestvibedev/tromcho.net
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix RDMA send buffer wraparound - could only lead to slower sending but not to corruption because the bug was canceled by send_out_pos >= send_done_pos check

Browse Source
This commit is contained in:
Vitaliy Filippov
2026-05-11 16:28:03 +03:00
parent 2fb6eb0c30
commit fdaf7c88ff
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/msgr_rdma.cpp
+4 -2
View File
@@ -612,7 +612,9 @@ void osd_messenger_t::try_send_rdma(osd_client_t *cl)
while (!rc->send_out_full && copied > 0 && rc->cur_send < rc->max_send) while (!rc->send_out_full && copied > 0 && rc->cur_send < rc->max_send)
{ {
dst = (uint8_t*)rc->send_out.buf + rc->send_out_pos; dst = (uint8_t*)rc->send_out.buf + rc->send_out_pos;
dst_len = (rc->send_out_pos < rc->send_out_size ? rc->send_out_size-rc->send_out_pos : rc->send_done_pos-rc->send_out_pos); dst_len = (rc->send_out_pos >= rc->send_done_pos
? rc->send_out_size-rc->send_out_pos
: rc->send_done_pos-rc->send_out_pos);
if (dst_len > rc->max_msg) if (dst_len > rc->max_msg)
dst_len = rc->max_msg; dst_len = rc->max_msg;
copied = try_send_rdma_copy(cl, dst, dst_len); copied = try_send_rdma_copy(cl, dst, dst_len);
@@ -622,7 +624,7 @@ void osd_messenger_t::try_send_rdma(osd_client_t *cl)
if (rc->send_out_pos == rc->send_out_size) if (rc->send_out_pos == rc->send_out_size)
rc->send_out_pos = 0; rc->send_out_pos = 0;
assert(rc->send_out_pos < rc->send_out_size); assert(rc->send_out_pos < rc->send_out_size);
if (rc->send_out_pos >= rc->send_done_pos) if (rc->send_out_pos == rc->send_done_pos)
rc->send_out_full = true; rc->send_out_full = true;
ibv_sge sge = { ibv_sge sge = {
.addr = (uintptr_t)dst, .addr = (uintptr_t)dst,