Vitaliy Filippov
278852b4d5
How many (bugs!) I've knifed, how many I've slit! General note: most bug fixes now include regression tests to verify that they don't repeat in the future. Most bugs fixed in this release were detected by using LLM analysis (Claude Opus/Fable, GPT 5.5). OSD: - Fix OSD hanging with an infinite loop when setting autosync_interval to 0 at runtime - (IMPORTANT) Fix EC PGs hanging in REPEERING when the last final commit/rollback in a batch completes with an error - Limit pg_size by 64 because peering doesn't handle larger values with EC — they just lead to 'incomplete' objects - Fix OSD crash with an "assertion failed" error on EIO retry in snapshot chain read (i.e. when some chunks belong to a corrupted replica with checksum mismatch) - (IMPORTANT) Disable chunked PG count resharding due to possible interference with compaction changes (will be re-enabled after fixes) - (IMPORTANT) Fix incorrect snapshot allocation bitmap recovery during EC chained read - Add on-wire request size validation to prevent possible OOM/DoS/heap corruption on receiving invalid data from the network - (IMPORTANT) Fix parity-less EC writes destroying snapshot allocation bitmaps (i.e. when all parity OSDs in a PG are missing) - (IMPORTANT) Fix EC N+K, K>=2 recovery destroying snapshot allocation bitmaps of live parity chunks - (IMPORTANT) Fix a possible OSD crash during EC misplaced object scrubbing - (IMPORTANT) Verify object bitmap consistency during scrub (only data was checked previously) - (IMPORTANT) Fix corrupted object chunks incorrectly marked as non-corrupted on the second scrub - (IMPORTANT) Fix cached EC decoding of multiple stripes with ISA-L (ISA-L is the default) New store: - Fix a theoretically possible OSD crash on startup when using the previously added workaround for the "double-claim" problem - Remove theoretically possible incorrect metadata block writes during batch EC COMMITs restarted due to a full metadata area - Fix incorrect compaction counter tracking after OSD restart (could probably lead to compaction not restarted correctly after a restart) - (IMPORTANT) Fix some of parallel big_writes possibly not waiting for data fsync, thus not providing durability - Fix possible OSD crash on sync retry when io_uring is full - Fix a possible crash during startup on corrupted on-disk data with too small entry sizes Old store: - Prevent loading extra garbage metadata entries from the last 4 MB of metadata area - Fix read operations possibly crashing if a metadata read (with inmemory_metadata=false) was restarted due to a full io_uring - Fix a possible memory leak of temporary buffers and bitmaps/checksums when a read was restarted due to a full io_uring (reproducible with either inmemory_metadata=false or block_size>256k) - Fix a possible OSD crash during padded checksum reads if buffer count exceeded 1024 (IOV_MAX) (reproducible only with csum_block_size > 4k and block_size >= 4M) - (IMPORTANT) Fix partial padded read journal checksum verification with csum_block_size > 4k - Fix incorrect marking of corrupted objects as non-corrupted after flushing data from journal (with inmemory_journal=false) - (IMPORTANT) Fix deferred freeing of a different block when a block was used by a parallel read - Fix per-inode statistics not being disabled for FS and S3 pools correctly, leading to etcd overload with unneeded per-inode statistics, slower etcd operation, increased memory usage, and too many Prometheus statistics exported by the monitor Both stores: - Fix possibly left garbage in the metadata area if the first OSD startup was interrupted — metadata header is now written only after initializating metadata - Check for short reads during initialization (just in case, doesn't happen in real life) Clients: - Fix write-back queue item split in case when write-back is enabled at runtime - Implement bdrv_detach_aio_context & bdrv_attach_aio_context in the QEMU driver (should fix migration with iothread) - Do not crash on full io_uring in ublk server - Fix missing --readonly option handling in NBD server - Stop gracefully on NBD_CMD_DISC instead of just exit(0) in NBD server - Fix writeback detection in ublk server for --image mode - Limit the amount of incoming data for NFS clients to prevent choking on memory in async mount mode Tools (vitastor-disk/vitastor-cli): - Prevent vitastor-cli merge possibly exiting before completing the last sync/delete operations - Fix vitastor-disk incorrectly validating too large small_write entry length - Fix vitastor-cli merge ignoring input option validation errors - Fix vitastor-cli rm-data always skipping the final fsync - Fix vitastor-disk resize not moving the last used data block - Fix vitastor-disk write-meta incorrectly importing new store small_write entries - Fix vitastor-disk write-journal and write-meta importing old store data incorrectly when csum_block_size is > 4k - Support --io option for vitastor-disk dump-journal/write-journal - Fix vitastor-disk resize crash when converting from very old (0.5.x) metadata - Fix vitastor-disk trim incorrectly rounding block ranges with --discard_granularity option explicitly set to a value > 4k, possibly leading to discarding live data - Fix vitastor-disk write-meta importing new store metadata incorrectly with > 4 GB metadata area size - (IMPORTANT) Fix vitastor-cli modify --resize to a smaller size clearing all image data O_o Other: - Do not crash with an uncaught exception when an invalid /osd/state/ with a non-numeric suffix is present in etcd (in OSD and all client services) - Fix possible crash in vitastor-kv when handling a corrupted DB due to a uint32 overflow - Fix NFS-RDMA memory allocator crashing in some situations - Fix small shared file extend-write potentially reading unallocated memory (NFS) - Add bounds checks to prevent uint32 overflows in NFS/XDR - Re-enable accidentally disabled safety checks (asserts) in files with included cpp-btree - Fix too small memory allocation in NFS portmap
146 lines
4.4 KiB
YAML
146 lines
4.4 KiB
YAML
---
|
|
kind: DaemonSet
|
|
apiVersion: apps/v1
|
|
metadata:
|
|
namespace: vitastor-system
|
|
name: csi-vitastor
|
|
spec:
|
|
selector:
|
|
matchLabels:
|
|
app: csi-vitastor
|
|
template:
|
|
metadata:
|
|
namespace: vitastor-system
|
|
labels:
|
|
app: csi-vitastor
|
|
spec:
|
|
serviceAccountName: vitastor-csi-nodeplugin
|
|
hostNetwork: true
|
|
hostPID: true
|
|
priorityClassName: system-node-critical
|
|
# to use e.g. Rook orchestrated cluster, and mons' FQDN is
|
|
# resolved through k8s service, set dns policy to cluster first
|
|
dnsPolicy: ClusterFirstWithHostNet
|
|
containers:
|
|
- name: driver-registrar
|
|
# This is necessary only for systems with SELinux, where
|
|
# non-privileged sidecar containers cannot access unix domain socket
|
|
# created by privileged CSI driver container.
|
|
securityContext:
|
|
privileged: true
|
|
image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.2.0
|
|
args:
|
|
- "--v=5"
|
|
- "--csi-address=/csi/csi.sock"
|
|
- "--kubelet-registration-path=/var/lib/kubelet/plugins/csi.vitastor.io/csi.sock"
|
|
env:
|
|
- name: KUBE_NODE_NAME
|
|
valueFrom:
|
|
fieldRef:
|
|
fieldPath: spec.nodeName
|
|
volumeMounts:
|
|
- name: socket-dir
|
|
mountPath: /csi
|
|
- name: registration-dir
|
|
mountPath: /registration
|
|
- name: csi-vitastor
|
|
securityContext:
|
|
privileged: true
|
|
capabilities:
|
|
add: ["SYS_ADMIN"]
|
|
allowPrivilegeEscalation: true
|
|
image: vitalif/vitastor-csi:v3.0.14
|
|
args:
|
|
- "--node=$(NODE_ID)"
|
|
- "--endpoint=$(CSI_ENDPOINT)"
|
|
env:
|
|
- name: NODE_ID
|
|
valueFrom:
|
|
fieldRef:
|
|
fieldPath: spec.nodeName
|
|
- name: CSI_ENDPOINT
|
|
value: unix:///csi/csi.sock
|
|
imagePullPolicy: "IfNotPresent"
|
|
ports:
|
|
- containerPort: 9898
|
|
name: healthz
|
|
protocol: TCP
|
|
livenessProbe:
|
|
failureThreshold: 5
|
|
httpGet:
|
|
path: /healthz
|
|
port: healthz
|
|
initialDelaySeconds: 10
|
|
timeoutSeconds: 3
|
|
periodSeconds: 2
|
|
volumeMounts:
|
|
- name: socket-dir
|
|
mountPath: /csi
|
|
- mountPath: /dev
|
|
name: host-dev
|
|
- mountPath: /sys
|
|
name: host-sys
|
|
- mountPath: /run/mount
|
|
name: host-mount
|
|
- mountPath: /run/vitastor-csi
|
|
name: run-vitastor-csi
|
|
- mountPath: /lib/modules
|
|
name: lib-modules
|
|
readOnly: true
|
|
- name: vitastor-config
|
|
mountPath: /etc/vitastor
|
|
- name: plugin-dir
|
|
mountPath: /var/lib/kubelet/plugins
|
|
mountPropagation: "Bidirectional"
|
|
- name: mountpoint-dir
|
|
mountPath: /var/lib/kubelet/pods
|
|
mountPropagation: "Bidirectional"
|
|
- name: liveness-probe
|
|
securityContext:
|
|
privileged: true
|
|
image: quay.io/k8scsi/livenessprobe:v1.1.0
|
|
args:
|
|
- "--csi-address=$(CSI_ENDPOINT)"
|
|
- "--health-port=9898"
|
|
env:
|
|
- name: CSI_ENDPOINT
|
|
value: unix:///csi/csi.sock
|
|
volumeMounts:
|
|
- mountPath: /csi
|
|
name: socket-dir
|
|
volumes:
|
|
- name: socket-dir
|
|
hostPath:
|
|
path: /var/lib/kubelet/plugins/csi.vitastor.io
|
|
type: DirectoryOrCreate
|
|
- name: plugin-dir
|
|
hostPath:
|
|
path: /var/lib/kubelet/plugins
|
|
type: Directory
|
|
- name: mountpoint-dir
|
|
hostPath:
|
|
path: /var/lib/kubelet/pods
|
|
type: DirectoryOrCreate
|
|
- name: registration-dir
|
|
hostPath:
|
|
path: /var/lib/kubelet/plugins_registry/
|
|
type: Directory
|
|
- name: host-dev
|
|
hostPath:
|
|
path: /dev
|
|
- name: host-sys
|
|
hostPath:
|
|
path: /sys
|
|
- name: host-mount
|
|
hostPath:
|
|
path: /run/mount
|
|
- name: run-vitastor-csi
|
|
hostPath:
|
|
path: /run/vitastor-csi
|
|
- name: lib-modules
|
|
hostPath:
|
|
path: /lib/modules
|
|
- name: vitastor-config
|
|
configMap:
|
|
name: vitastor-config
|